1
Vote

VersionResource.LoadFrom and language considerations

description

This is a really great project, it's just unfortunate with the tiny glitches that make it frustrating to get started.

In the article and in the CHM file there is an example "Writing Version Information". Unfortunately, it doesn't work "out of the box", at least not for me.

VersionResource.LoadFrom(filename) is capturing the version information OK, but it sets the Language property to the local language or something, for me 1033, despite the language for the RT_VERSION resource in the file being 0.

So at the end of the example the statement "versionResource.SaveTo(filename);" does not update the existing version information; instead it creates a new RT_VERSION resource with language 1033 alongside the original one with language 0.

Adding the statement "versionResource.Language = 0;" fixes the problem. (But first after you've spent a lot of time trying to figure out what's wrong.)

Thanks again for a great project.

comments

dblock wrote May 18, 2011 at 5:05 PM

Maybe you can send a patch that fixes the doc? Thanks.

RenniePet wrote May 20, 2011 at 12:53 PM

Sorry, I'm not familiar with the procedure for creating a "patch". It would take me much, much longer to do that than for you to make the corresponding fix.

By the way, it's a small world. I actually made a couple of very, very tiny contributions to the dotNetInstaller program long ago (five years ago?). So I was surprised to see it here, now under your auspices.

dblock wrote May 20, 2011 at 3:00 PM

@RenniePet: sure, sure, it's easier when other people do things :) There's a doc on how to contribute.

dblock wrote May 20, 2011 at 3:00 PM

In the CHM that is ...